For the last two decades the immunotherapy of patients with solid and hematopoietic tumors has met with variable success. We have reviewed the field of tumor vaccines to examine what has worked and what has not, why this has been the case, how the anti-tumor responses were examined, and how we can make tumor immunity successful for the majority of individuals rather than for the exceptional patients who currently show successful immune responses against their tumors.